Remove Party Member update #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1358) - new party message about changing leader - CPartyDef::RemoveMember refactoring
Contributor
|
Merging, could you please add PARTY_CHANGE_LEADER to the script pack? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: not removing party member from member list (#1475)
Feature: when party leader disconnects or is removed from game, change party leader to another person instead of disbanding the party. While leader lingers, he keeps the party leader position (possible fix for #1358).
There is no solution, when party leader removes himself from the party, since the packet for disbanding and removing leader is the same.